Added rackup dependency for Rack 3 compatibility

jeremyevans / rodauth

Ruby's Most Advanced Authentication Framework

http://rodauth.jeremyevans.net

MIT License

1.65k stars 95 forks source link

Added rackup dependency for Rack 3 compatibility #351

Closed igor-alexandrov closed 12 months ago

igor-alexandrov commented 1 year ago

Description

In Rack 3 bin/rackup (that is used to serve local version of documentation) has been moved to a separate gem: https://github.com/rack/rack/blob/main/UPGRADE-GUIDE.md#binrackup-rackserver-rackhandlerand--racklobster-were-moved-to-a-separate-gem.

jeremyevans commented 12 months ago

rackup isn't required. You can use any webserver that supports rack applications.

igor-alexandrov commented 12 months ago

@jeremyevans but rackup is used by default to run local web server in Rakefile: https://github.com/jeremyevans/rodauth/blob/master/Rakefile#L224C5-L224C5.

This is why I added it.

jeremyevans commented 12 months ago

Ah, that makes sense. I think in this case, we are better off removing the serve task and www/config.ru, as the files are just static files and all links are relative. I'll do that.