Allow explicit usage of `p_cost` in argon2 feature.

jeremyevans / rodauth

Ruby's Most Advanced Authentication Framework

http://rodauth.jeremyevans.net

MIT License

1.65k stars 95 forks source link

Allow explicit usage of `p_cost` in argon2 feature. #353

Closed estebanz01 closed 12 months ago

estebanz01 commented 12 months ago

Based on a discussion on #349 where I ran into a small issue when a custom hash cost for argon2 was specified, this PR implements the explicit usage of the p_cost attribute that can be defined when hashing passwords with this particular algorithm.

I didn't run any linter on my changes as I'm not sure which one is used or if there's some specific configuration I need to have.

All test passed on postgresql and ruby 3.2.2, but I can try other versions/databases if needed.

estebanz01 commented 12 months ago

@jeremyevans not sure if you get a notification for open PRs, so I'm going to ping you here 😅 sorry for any duplicated alerts.

jeremyevans commented 12 months ago

Looks good, thanks for the patch! I'll do some testing locally and merge if there are no problems.

I do get notified about open PRs, otherwise it would be difficult to ensure that all PRs are addressed quickly.

jeremyevans commented 12 months ago

Squash merged at 49ffc7ee22fd95e4b3dfa086e2629ca3666f8de9