set nice autofocus on login/password field (autofocus will go to first field with attribute set)

jeremyevans / rodauth

Ruby's Most Advanced Authentication Framework

http://rodauth.jeremyevans.net

MIT License

1.65k stars 95 forks source link

set nice autofocus on login/password field (autofocus will go to first field with attribute set) #420

Closed jf closed 1 month ago

jf commented 2 months ago

Note:

I did not opt for the same approach as for autocomplete, inputmode, etc. because for HTML, setting autofocus="<any string>" will only serve to activate autofocus
because it is ok to have autofocus on multiple fields (only the first field will get autofocus-ed), I opted to have autofocus for both the login, and the password field, so when rodauth.skip_login_field_on_login? is true, the autofocus then goes to the password field

jeremyevans commented 2 months ago

I'm OK with supporting autofocus as a feature. I'm not sure whether we want it to default to on, and certainly there should be a way to configure the behavior. We should have tests that checks whether it is set depending on configured behavior. And if we are doing it for these, we should consider doing it for other cases as well (OTP, recovery key, maybe others).

jf commented 2 months ago

ok. I didnt think about the other forms, but yes, that makes sense. I will get to this soon-ish, but give me some time.

jeremyevans commented 1 month ago

@jf are you still planning to work on this?

jf commented 1 month ago

hi @jeremyevans so sorry about this. My apologies. I've moved on from using rodauth (no fault of rodauth's, btw), and this has slipped my mind. If I ever come back to using rodauth, this will be something I will work on. Again, my apologies.

jeremyevans commented 1 month ago

No problem, thanks for getting back to me.