search

jeremyevans / sequel

Sequel: The Database Toolkit for Ruby
http://sequel.jeremyevans.net
Other
4.98k stars 1.07k forks source link

Sharding docs: Cleary state that :read_only is a special key #2043

Closed TSMMark closed 1 year ago

TSMMark commented 1 year ago

One of my senior teammates is not convinced from the documentation that :read_only is a special key that induces a certain automatic behavior with how read vs write queries are handled.

After I read the docs again, I was not sure anymore either. It seems implied, but never clearly stated.

This PR adds additional description that is to my best understanding.

Please update or correct as needed. I feel that some additional clarification here could definitely help Sequel users

jeremyevans commented 1 year ago

Thanks for the patch! I'll merge and reword.