search

jeremyevans / sequel

Sequel: The Database Toolkit for Ruby
http://sequel.jeremyevans.net
Other
4.98k stars 1.07k forks source link

raise error when connection_validator is loaded in single threaded mode #2049

Closed HoneyryderChuck closed 1 year ago

HoneyryderChuck commented 1 year ago

While, as per the discussion in #2042 , sequel is doing what is supposed to as per what's documentedd, the error is still cryptic and not obvious when one falls in the trap.

This patch adds a more helpful error message, which is aligned with other similar messages for other extensions which aren't supported in single threaded mode as well.

jeremyevans commented 1 year ago

Thanks for the patch. I'll do some testing with it tomorrow. It looks like the connection_validator extension is not compatible with the timed_queue connection pool, which should definitely be fixed.

jeremyevans commented 1 year ago

Cherry picked as acb8bca5ebd7d61a9765835eab1ddfea37999658