search

jeremyevans / sequel

Sequel: The Database Toolkit for Ruby
http://sequel.jeremyevans.net
Other
4.97k stars 1.07k forks source link

Support SKIP LOCKED for MariaDB 10.6+. #2150

Closed simi closed 5 months ago

simi commented 5 months ago

Should be supported according to https://mariadb.com/kb/en/select/#skip-locked. I have tested locally and it works well. I wasn't able to find out any specs to cover this.

jeremyevans commented 5 months ago

Thanks for the patch! There are integration tests for this, so I should be able to test tomorrow if it works. I think GitHub CI is MySQL and not MariaDB, so GitHub CI wouldn't be able to test this.

simi commented 5 months ago

Thanks for the patch! There are integration tests for this, so I should be able to test tomorrow if it works. I think GitHub CI is MySQL and not MariaDB, so GitHub CI wouldn't be able to test this.

I have tested locally with version() = 10.11.5-MariaDB-1:10.11.5+maria~ubu1804-log. Indeed current GitHub Actions is MySQL only.