search

jeremyfa / spine-hx

Spine runtime for Haxe automatically converted from the official Java/libgdx runtime
Other
56 stars 15 forks source link

Add SkeletonBinary class for loading binary files #10

Closed Beeblerox closed 6 years ago

Beeblerox commented 6 years ago

@jeremyfa Hello, i think that you might be interested in adding this class to spine-hx library. I had to manually convert it from c# class https://github.com/EsotericSoftware/spine-runtimes/blob/3.6/spine-csharp/src/SkeletonBinary.cs because i couldn't find one for haxe and i needed it for my current work (since i have some memory issues with json-files). Loading skeletons from json-files is fine, but binary files are take much less space (they are 2-3 times smaller), they are parsed about 10 times faster (in my tests) and have less memory footprint. I've tested this class on hxcpp and js targets, so i think it should work fine on others too.

jeremyfa commented 6 years ago

Thanks a lot for this PR, binary loading indeed a useful thing to add. I am merging your manually converted version for now!

In the future, it would be better if SkeletonBinary is converted automatically from java/libgdx runtime, just like the rest. Your implementation would actually be helpful to implement the automatic conversion as well as it provides a working example that I can compare to when testing the automatic conversion.

Beeblerox commented 6 years ago

@jeremyfa i'll try to help when the format will be updated, just message me