search

jeremyfa / spine-hx

Spine runtime for Haxe automatically converted from the official Java/libgdx runtime
Other
56 stars 15 forks source link

fixed _gotoLabel_outer #28

Closed PadTwo closed 2 years ago

PadTwo commented 2 years ago

Fixed triangulate function to match https://github.com/EsotericSoftware/spine-runtimes/blob/4.0/spine-libgdx/spine-libgdx/src/com/esotericsoftware/spine/utils/Triangulator.java

Probably some issues with label conversion.

jeremyfa commented 2 years ago

Hi, thanks for the PR!

However I'd like to merge a cleaner change. Here you used different indentation (tabs) than what the original file uses (spaces) and it makes it difficult to read what was actually changed. There are also trailing whitespaces that have been added.

Could you submit another pull request that only contains the relevant changes?

PadTwo commented 2 years ago

Should be all clean now, let me know if you need any other changes otherwise i will submit the new pull request.

jeremyfa commented 2 years ago

Thanks, I'll merge it as is for now. Eventually I'll have to check the conversion script to see if it can convert the code properly, but that will do for now.