search

jeremyhansen / rooksguide-cplusplus

The Rook's Guide to C++
44 stars 12 forks source link

Pointers, Strings, and Loops #12

Closed LeviSchuck closed 10 years ago

LeviSchuck commented 11 years ago

I'd like to assign myself these chapters so that I can do them without worry of duplicate work

I will be traveling via car for a good while, so I thought I'd take on these chapters while I have no internet next week.

jeremyhansen commented 11 years ago

STL is mostly converted, but strings and pointers are yours. How about adding loops?

LeviSchuck commented 11 years ago

Good thing I brought this up then.

Sure, I'll take on loops.

LeviSchuck commented 11 years ago

Alright, I've put up the strings content. I do not think it was well written by the original author, but I've got the content together now from the resources.

Can I have feedback on how it is, how the source LaTeX matches the style guide and so on?

My only comment is that I think the content is weakly written and the flow feels amateurish, but I'll leave that for later.

One issue I had is a reference to a figure that is not in the original content, nor content in the strings folder, though it refers to strings. I've put a TODO: ... inside, and the output PDF says "Figure ??"

LeviSchuck commented 11 years ago

Alright, I've added loops now. Can I please get feedback on my work so far?

Also, there are missing figures / diagrams in loops. I could make them with graphviz.

jeremyhansen commented 11 years ago

chap_loops.tex looks good, but there are some left over Unicode characters from copy/pasting from OpenOffice and Word. Here's what I see at line 221, for example:

Take a look at the example below, then let’s talk our way through it.

I fixed that chapter, but the LaTeX in the others look fine. (There was one other spot, but I've fixed that, too)

If you want to create the diagrams, that would be great. I'm not sure about the "fig-stringfind" figure. If it's not in the source material, feel free to remove the reference or create an appropriate diagram. Your call!

As for the quality of the writing, I agree, there are some spots that are not well-written. Remember that this was largely written by college freshmen over a 36 hour period. :) If you can rephrase things to make it sound better, go for it!

LeviSchuck commented 11 years ago

Thanks for the bad character catch!

The strings chapter was pretty bad, but loops were fine in terms of starting quality.

I will typeset the pointers soon and then revise the strings chapter. I'll mention your name (and hopefully get a notification pushed to you) when I'm ready for a review on that. Then perhaps this issue can be closed! :octocat:

LeviSchuck commented 10 years ago

I plan to jump back into this, I have been busy trying to apply for jobs and such.

Please make sure you have everything pushed and up to date! :)

jeremyhansen commented 10 years ago

Hi Levi, glad to have you back!

Take a look at what I’ve done with the Advanced Arithmetic chapter, in particular on how the source code chunks are formatted within a minipage (I believe that you may have done the first minipage) with \linewidth instead of \textwidth.

I think I’m going to get rid of all the “homework” exercises, as they’re not very deep and roll them into the review exercises. There are also chapters that had review/homework exercises in the source material that didn’t get over yet.

If you’d rather tackle something different, there are diagrams in a handful of places that need to be recreated in a consistent and attractive way. Let me know what you’d prefer to work on so we don’t duplicate efforts.

Good luck on the job hunt!

Jeremy

From: Levi [mailto:notifications@github.com] Sent: Tuesday, November 05, 2013 11:14 AM To: jeremyhansen/rooksguide-cplusplus Cc: Jeremy Hansen Subject: Re: [rooksguide-cplusplus] Pointers, Strings, and Loops (#12)

I plan to jump back into this, I have been busy trying to apply for jobs and such.

Please make sure you have everything pushed and up to date! :)

— Reply to this email directly or view it on GitHubhttps://github.com/jeremyhansen/rooksguide-cplusplus/issues/12#issuecomment-27786467.

LeviSchuck commented 10 years ago

I have changed strings and loops over to use \linewidth instead.

LeviSchuck commented 10 years ago

I also went ahead and tried to solve where content was going off the side of the page.

There's gotta be a better way to do all this... The output log looks like a giant rolling snow ball just waiting to crash.