search

jeremyhansen / rooksguide-cplusplus

The Rook's Guide to C++
44 stars 12 forks source link

Missing Figures #16

Closed LeviSchuck closed 10 years ago

LeviSchuck commented 10 years ago

Jeremy, I noticed you put up some figures today/last night, and I just got to adding some as well.

Currently we have

LaTeX Warning: Reference `fig-stringfind' on page 62 undefined on input line 12
LaTeX Warning: Reference `fig-netbeans-syntax-error' on page 91 undefined on in
LaTeX Warning: Reference `fig_studentsmap' on page 146 undefined on input line

missing.

I just added if and if-else diagrams in the conditional chapter. Please review them and give feedback.

jeremyhansen commented 10 years ago

Thanks - I shifted the \label to be after the \caption so that the numbering works out right.

In the first diagram, would you move "True and {" to the left of the arrow, so that it's not confused with the arrow to the right? Similarly, moving "True but no { found" down closer to the "statement" circle would make the label less ambiguous. The leftmost "no else found" should also be moved to the left of the arrow.

If you could change the text in the second diagram to say "Outputs..." rather than "puts ...", I think it would be more consistent with the rest of the text.

If you see changes that you'd like to make in the material (I saw a note in conditionals.tex to that effect), go ahead and change it. I may go back and edit it slightly, but there's a lot of room for improvement down the road. So, especially if there's something that's downright wrong or misleading, you have permission to fix whatever you find.

Thanks! Jeremy

LeviSchuck commented 10 years ago

Jeremy,

Can you take a look at the diagrams now?

LeviSchuck commented 10 years ago

I think the netbeans figures in the problems chapter should be shrunk before having a screenshot, such that the text is easier to read, especially in the build messages section.

jeremyhansen commented 10 years ago

The if-flow diagram is still a little awkward, but informative. I'll take a crack at the Netbeans screen caps shortly.

LeviSchuck commented 10 years ago

I have redone that diagram to be to-the-point, and have added a small subsection "A small digression on expressions".

In this subsection, I describe the differences between using braces, not using braces, and the consequences. I also show another bear trap that about every single programmer out there hits at some point.

Please give feedback on these changes to the conditionals chapter.

jeremyhansen commented 10 years ago

Looks good! I've made a few minor changes, and am in the home stretch today of edits before sending this to the printer.