Closed jason-horvath closed 4 years ago
Fixed that unit test warning I mentioned earlier. All passing green now!
Thanks for the PR, much appreciated!
I'll get travis working again (it got turned off somehow) and tag this ASAP.
Merging #24 into master will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## master #24 +/- ##
=======================================
Coverage 100% 100%
Complexity 18 18
=======================================
Files 1 1
Lines 44 44
=======================================
Hits 44 44
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
src/ORM/LazyLoadEntityTrait.php | 100% <100%> (ø) |
18 <4> (ø) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 9c4298a...202bce1. Read the comment docs.
@KainGNX released: https://github.com/jeremyharris/cakephp-lazyload/releases/tag/4.0.0
Thanks again for the legwork :)
You're welcome! Glad I could help! :D
Been going through a tedious 3.x to 4.x upgrade, and came across this change.
The
EntityTrait::$_properties
has now becomeEntityTrait::$_fields
https://api.cakephp.org/3.8/source-class-Cake.Datasource.EntityTrait.html#29-34
https://github.com/cakephp/cakephp/blob/master/src/Datasource/EntityTrait.php#L37
My unit tests relying on lazy-loading appear to be passing now. Just thought I'd share to help everyone out. :)
PS: I would pick a dev branch if I could.