search

jeremyharris / cakephp-lazyload

A lazy loader for CakePHP entities.
MIT License
61 stars 10 forks source link

Fix for unconventional PKs #31

Closed jeremyharris closed 2 years ago

jeremyharris commented 2 years ago

refs: #29, #30

jeremyharris commented 2 years ago

ping @lordphnx

Any chance you were able to test your codebase against these changes?

lordphnx commented 2 years ago

@jeremyharris thanks for reminding me! Just ran the tests in one of my codebases:

So looks to be all good 😄

jeremyharris commented 2 years ago

@lordphnx Thanks again for the report and for spending so much of your time working through this bug with me! I appreciate it!

lordphnx commented 2 years ago

No worries, have enjoyed the process, and appreciate your patience with my newbie-ness in the entire bug/PR process 😄