search

jeremyherbert / mcp2210-python

MCP22100 python driver
MIT License
6 stars 4 forks source link

logs from the module mess up the root logger #12

Closed ashokbruno closed 1 month ago

ashokbruno commented 1 month ago

A better way to log messages would be log in a specific log for more control. This would allow the log to be disabled by upstream code using this module. For instance, this change would be modify line15 of mcp2210.py to:

logger = logging.getLogger(name)

jeremyherbert commented 1 month ago

Thank you for this. I have just pushed 1.0.7 to pypi with your fix included.

ashokbruno commented 1 month ago

Thanks!

On Thu, Aug 15, 2024, 10:20 PM Jeremy Herbert @.***> wrote:

Thank you for this. I have just pushed 1.0.7 to pypi with your fix included.

— Reply to this email directly, view it on GitHub https://github.com/jeremyherbert/mcp2210-python/issues/12#issuecomment-2292612844, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACP2XUPHIPZZ756A4PU3WX3ZRVOW7AVCNFSM6AAAAABMPA73JSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJSGYYTEOBUGQ . You are receiving this because you authored the thread.Message ID: @.***>