search

jeremyjevon / ICT2X01-Team-Project-P3-6

ICT2101/2201 Team Project
1 stars 0 forks source link

Login [v1.0] - Restyled Login #30

Closed thomaslwk closed 2 years ago

thomaslwk commented 2 years ago

Hi team,

Upon some further testing of the login UI, there appears to be an unforeseen UI issue that did not occur previously. The dark background of the input box with the black text might become an accessibility issue as the overall colour contrast of the UI is too dark.

Proposed consideration to switch the text input boxes to use a white background instead to increase overall visibility of the login UI.

Tldr: Change css of textinput box to be black text on white background.

Thanks!

(Attached is a screenshot of the UI on my end.)

dark
syongkheng commented 2 years ago

Hi,

I have made the necessary changes, and submitted a PR for your review. Hope to hear "LGTM" from you!

thomaslwk commented 2 years ago

Good day,

It is working on my end now. I can see the text much better now with the white background. Thanks for the quick update!

syongkheng commented 2 years ago

Alright, since it has been successfully merged with no issues, I will close the issue now.