search

jeremyjh / dialyxir

Mix tasks to simplify use of Dialyzer in Elixir projects.
Apache License 2.0
1.7k stars 140 forks source link

Hex bump RC1 #194

Closed asummers closed 6 years ago

asummers commented 6 years ago

@jeremyjh mind bumping? Should eliminate a bunch of the issues people are opening after the merge this morning.

jeremyjh commented 6 years ago

Agreed, I was just waiting to see if that last one was fixed in master.

asummers commented 6 years ago

Makes sense 😄

asummers commented 6 years ago

Still throughly confused why my PR fixed anything, I'll have to investigate that at some point.

asummers commented 6 years ago

If anything, I should have just gotten a better error message, but that last guy's issue was legitimately fixed in #192... Unsure how that's possible. Is it possible the original hex push wasn't pulled master?

jeremyjh commented 6 years ago

I don't see how that is possible, because the version in mix.exs is used by hex to publish it. So it wouldn't show up in hex.pm with that version number unless it were based on those sources.

I was also surprised it fixed anything, I wonder is it swallowing a warning now for them?

Push of rc.1 is literally blocked on this issue: https://github.com/hexpm/hexpm/issues/690

asummers commented 6 years ago

I buy the mix.exs argument. Just trying to think outside the box for that.

I'd share your suspicion of the error swallow except it seemed like the same error was printing the actual message after that point. I'm very confused.

Hex errors are no bueno :(

asummers commented 6 years ago

Additionally the rescue even being necessary is completely confusing because the lexing error was being explicitly thrown/caught.

jeremyjh commented 6 years ago

I thought the lexing error was thrown by Erlang code? That would always be an exception that must be rescued.

asummers commented 6 years ago

https://github.com/jeremyjh/dialyxir/blob/master/lib/dialyxir/pretty_print.ex

lex/1 is already doing that though. The tuple was that one being thrown.

Then that was being explicitly caught in format_warning in

https://github.com/jeremyjh/dialyxir/blob/master/lib/dialyxir/formatter.ex

jeremyjh commented 6 years ago

Ah, I see. Yeah I don't understand either then.

jeremyjh commented 6 years ago

rc.1 is published

jeremyjh commented 6 years ago

I know what the issue was; we didn't add the new files in src to the file list for Hex. So its only working when pulled via git. Will push a new RC shortly.

asummers commented 6 years ago

GOOD CALL!!!