search

jeremykendall / php-domain-parser

Public Suffix List based domain parsing implemented in PHP
MIT License
1.16k stars 128 forks source link

updated cache-key to be universally psr-16 compliant #214

Closed dochne closed 6 years ago

dochne commented 6 years ago

Introduction

Currently the library uses cache keys that contain hyphens. According to the PSR specification only the characters A-Z, a-z, 0-9, _, and . are required to be supported, and in the case of many implementations (specifically some of the psr-endorsed libraries such as cache/filesystem-adapter) they set a hard requirement that your key must only use those characters.

Proposal

Describe the new/updated/fixed feature

Switching the use of the hyphen to an underscore instead. This will allow all PSR-16 compatible libraries to be used. See Issue #213

Backward Incompatible Changes

Anything in the cache will currently be lost? Nothing really.

Targeted release version

Depending on your cycle I guess 5.1.1 or 5.2.0

PR Impact

None.

Open issues

Mone

nyamsprod commented 6 years ago

Good catch and thanks for the contribution I will merge your PR and when 5.2.0 is ready hopefully this week or next week this fix will be released 🙌