Don't swallow cache errors

jeremykendall / php-domain-parser

Public Suffix List based domain parsing implemented in PHP

MIT License

1.16k stars 128 forks source link

Don't swallow cache errors #232

Closed AmazingDreams closed 5 years ago

AmazingDreams commented 5 years ago

Issue summary

I just spent an hour debugging an error about unable to load the domain information. Turned out the default cache implementation just swallows errors and fails with an irrelevant message.

System informations

Irrelevant

Standalone code, or other way to reproduce the problem

Make the default cache dir not writeable

Expected result

Relevant error message

Actual result

Irrelevant error message

nyamsprod commented 5 years ago

@AmazingDreams a bug fix has landed using the following PR #233 could you test it to see if it resolve your issue.

thanks in advance