IDNA options alternate setters

jeremykendall / php-domain-parser

Public Suffix List based domain parsing implemented in PHP

MIT License

1.16k stars 128 forks source link

IDNA options alternate setters #242

Closed nyamsprod closed 5 years ago

nyamsprod commented 5 years ago

@Insolita while reviewing the #236 I was wondering why not use

withAsciiIDNAOption and withUnicodeDNAOption instead of withIDNAOptions.

This branch apply all the changes to implement this solution. Is there a strong argument against this change ? Depending on your answer I'll merge or close this PR.