search

jeremykendall / php-domain-parser

Public Suffix List based domain parsing implemented in PHP
MIT License
1.16k stars 128 forks source link

Support PHP 8 #288

Closed szepeviktor closed 4 years ago

szepeviktor commented 4 years ago

Introduction

Support PHP 8 as tests already pass.

Fixes #287

szepeviktor commented 4 years ago

Giving up :(

nyamsprod commented 4 years ago

@szepeviktor thanks for the PR. I'll look into it more carefully this week but I'll have to admit I'm currently focused in finished the next major version of the library you can already see the code in the feature/v6 branch to be able to release it around the time PHP8 hits. Which means that the new version will support PHP7.4 and PHP8.

I might then release the two aroud the same time but I'll mainly focus on v6 and v5 will only receive security fixes if any for another 6 months.

szepeviktor commented 4 years ago

You're welcome. All right. Removing --ignore-platform-reqs should be enough.

nyamsprod commented 4 years ago

@szepeviktor I'll be switching the package over using githubs actions instead of travis. So I'll close this PR after and will make sure to include PHP8 in the actions like I've already did for the feature/v6 branch.

szepeviktor commented 4 years ago

Thank you.

szepeviktor commented 4 years ago

This is a highly usable integration test suite for PHP/GHA https://github.com/ergebnis/php-library-template/blob/main/.github/workflows/integrate.yaml