search

jeremykendall / php-domain-parser

Public Suffix List based domain parsing implemented in PHP
MIT License
1.16k stars 128 forks source link

Parsing domain with ip prefix will not work #347

Closed joe820912boy closed 1 year ago

joe820912boy commented 1 year ago

I found that some domain with ip prefix that the parser wouldn't work on it.

Like '1.1.1.1.cloudflare-dns.com' , the public suffix and top level domains just return nothing.

Does the parser not support this format, or is there anything I didn't notice it?

nyamsprod commented 1 year ago

@joe820912boy a PR has landed with a fix to this issue you can check, review and download it to see if all is fixed see #348

joe820912boy commented 1 year ago

@nyamsprod thanks for bug fixed for some special format domain

and it seems that this fix didn't release for the current version?

I run composer update it didn't update anything,

or should I manually edit the code?

joe820912boy commented 1 year ago

I have solved the problem by re-install the dev version.

composer require jeremykendall/php-domain-parser:develop-dev

Thanks!!