jeremykendall / php-domain-parser

Public Suffix List based domain parsing implemented in PHP
MIT License
1.16k stars 128 forks source link

Public Suffix List as a package #357

Closed szepeviktor closed 1 month ago

szepeviktor commented 1 month ago

Issue summary

Are there plans to release Public Suffix List as a Composer package?

nyamsprod commented 1 month ago

Hi @szepeviktor sorry but I fail to understand your question. The list does not need any package as it is maintained and made publicly available by Mozilla. Or you are thinking of something else 🤔

szepeviktor commented 1 month ago

When I use php-domain-parser I need to set up a mechanism to update the list. We could release the list as a Composer package with weekly updates.

nyamsprod commented 1 month ago

Previous versions of the package use to offer a cache mechanism. It was removed because the cache was never in sync with the Mozilla list or with the application settings. If you implement the new caching system as explain in the doc you should tbe fine. Also there's a companion package for Laravel which can be set for doing jist that. If you are not using Laravel you can create such package I will then link it in the documentation

szepeviktor commented 1 month ago

I am talking about making the cache mechanism unnecessary by releasing the list as a package.

nyamsprod commented 1 month ago

That's a bad idea because it gives a false sense a accuracy

nyamsprod commented 1 month ago

as an example see how the laravel package manage what you are asking:

https://distortedfusion.com/docs/kevindierkx/laravel-domain-parser/getting-started#configuration

to me that's how you should do it. Because you get the full control over the cache and when and how to update it. And since the integration is done on the. application level on daily usage you can completely forget about the cache and the copy.

szepeviktor commented 1 month ago

Okay. So you are against publishing the list as a package.