search

jeremykendall / php-domain-parser

Public Suffix List based domain parsing implemented in PHP
MIT License
1.16k stars 128 forks source link

Php 8.4 release? #358

Open JayceFFT opened 15 hours ago

JayceFFT commented 15 hours ago

Hi,

do you consider to create a release for php 8.4 support? Composer is downloading an old version.

Thanks

nyamsprod commented 15 hours ago

@JayceFFT Hi thanks for using the package. May I ask which version did you get 🤔. AFAIK the latest version is PHP 8.1+ compatible. So I do not understand your question?

JayceFFT commented 14 hours ago

Composer download from master by default IIRC. I had to change to "jeremykendall/php-domain-parser": "dev-develop" in require

JayceFFT commented 14 hours ago

and version 6.3.0 does not include commits for php 8.4

JayceFFT commented 14 hours ago

I need this commit: https://github.com/jeremykendall/php-domain-parser/commit/bf4783dfff8961eb9373bcf73d845ab0fee1dc54

To be a in release to avoid deprecated warnings

nyamsprod commented 14 hours ago

Ok got it ... Will see what I can do it's just a fix release nothing new

JayceFFT commented 14 hours ago

Thanks