connect should be a method of GObject, not Widget

jeremyletang / rgtk

GTK+ bindings and wrappers for Rust (DEPRECATED SEE https://github.com/rust-gnome )

GNU Lesser General Public License v3.0

121 stars 22 forks source link

connect should be a method of GObject, not Widget #118

Closed osa1 closed 9 years ago

osa1 commented 9 years ago

See https://developer.gnome.org/gobject/stable/gobject-The-Base-Object-Type.html#g-object-connect

osa1 commented 9 years ago

I think we need to do the following:

Add FFIGObject trait with get_gobject and wrap methods as usual.
Replace struct_Widget! with struct_GObject!.
Define GObject trait.
Widget trait should also enforce implementation of GObject.

I may be forgetting some intermediate steps.

I actually tried to do that but my Rust skills are simply not enough for the task. It was extremely annoying for me, I had to fight with problems related with name resolving and macros. Sorry for not helping with this.

GuillaumeGomez commented 9 years ago

I spoke about that a few times ago with @jeremyletang. For the moment, we both are quite busy but as soon as we have time, we'll speak again about that. But you're right, we need to create an Object trait and implement it in the Widget trait.

jeremyletang commented 9 years ago

hi @osa1,

We have plan to had a gobject trait. I've already think about this and how to implement it. This go with the signals refactor that we have planned. But has @GuillaumeGomez said we are a bit busy right now but we will try to work on this soon ( probably between today and this week end ).