update to latest rust-nightly

jeremyletang / rgtk

GTK+ bindings and wrappers for Rust (DEPRECATED SEE https://github.com/rust-gnome )

GNU Lesser General Public License v3.0

121 stars 22 forks source link

Closed andrewrk closed 9 years ago

andrewrk commented 9 years ago

Please review. It builds, but I didn't test it. Also I am new to rust; not sure of these changes.

andrewrk commented 9 years ago

I'm pretty sure this PR causes all Connect::connect calls to crash the program when the signal fires. :(

Looking into how to fix this, but struggling as this is my first rust program.

GuillaumeGomez commented 9 years ago

If you don't have find out what's wrong at the end on the week I'll try to help you (or @jeremyletang if he has time).

GuillaumeGomez commented 9 years ago

Hey ! You forgot to set your methods public and the problem with the trait was just a lifetime being shadowed. Check the #135 PR.

andrewrk commented 9 years ago

Thanks, it's helpful to see what the correct fix was after trying it myself.

GuillaumeGomez commented 9 years ago

No problem, don't hesitate to contribute !