search

jeremyletang / rgtk

GTK+ bindings and wrappers for Rust (DEPRECATED SEE https://github.com/rust-gnome )
GNU Lesser General Public License v3.0
121 stars 22 forks source link

Add a missing example crate to the build #196

Closed gkoz closed 9 years ago

GuillaumeGomez commented 9 years ago

We didn't add gtktest to the tests built because it cannot run under GTK 3.6. I was working on it. Look here.

gkoz commented 9 years ago

Oh, sorry :)

GuillaumeGomez commented 9 years ago

No problem ! However, if you find the solution I'm looking for, I'd be very glad haha. I want to make only one Cargo.toml file for all examples in order to not rebuild rgtk every time (that's a pain in the ass !). The problem is that I don't know how to pass the GTK version to the rgtk Cargo file:

> cd examples
> cargo build GTK_3_6

I asked and it was supposed to work but it's not.

gkoz commented 9 years ago

I'm not entirely sure I understood the problem, but take a look at how openssl handles passing features between crates: https://github.com/sfackler/rust-openssl/blob/master/openssl/Cargo.toml

gkoz commented 9 years ago

@GuillaumeGomez I feel that examples should just follow the convention of belonging to the library crate and being built with cargo test. The versions problem could be handled with macros, see https://github.com/gkoz/rgtk/commits/version_macros If someone's working on an example a lot, they could put it in a separate crate locally.

GuillaumeGomez commented 9 years ago

@gkoz: I have to test and confirm.