search

jeremyletang / rgtk

GTK+ bindings and wrappers for Rust (DEPRECATED SEE https://github.com/rust-gnome )
GNU Lesser General Public License v3.0
121 stars 22 forks source link

Split glib off into its own crate #205

Closed gkoz closed 9 years ago

gkoz commented 9 years ago

This was much easier. But we need to do something about the examples, travis tests are taking way too long.. :-P

GuillaumeGomez commented 9 years ago

Isn't it ? For the examples, I started to work on that here. But as you can see, this is a very old work. But that's the idea. I did the same on another repo of mine.

gkoz commented 9 years ago

Eh, I've looked at that branch but couldn't quite figure out what you did there :) Could you point to specific commits maybe?

GuillaumeGomez commented 9 years ago

The simpler will be a little explanation (which is quite simple). I wanted to create two Cargo files: one for rgtk and one for the examples. The problem I encountered was that I couldn't figure out how to pass the gtk version to the rgtk cargo file through the examples cargo file. Otherwise, it was done.

I hope I didn't lost you... Sorry if my explanations aren't clear.

gkoz commented 9 years ago

You can pass the features like this: https://github.com/jeremyletang/rgtk/blob/master/Cargo.toml#L14-19 Having an examples crate would still double the compilation times...

GuillaumeGomez commented 9 years ago

At first, we only had one cargo file. But my computer was overheating when building it and @jeremyletang found the compilation too long so we splitted the lib and the examples' compilations. A little too much however. We'll always have to have the double compilation time, but only once after that.

gkoz commented 9 years ago

Fair enough. :) Further separation of the crates should make the times more manageable though.

As to this PR, I've spotted a blemish, I think, I'll tweak the commit a bit...

gkoz commented 9 years ago

Done. When working on the wrappers redesign I've found that this crate needs a major rehaul too: I wasn't able to use List as is for interacting with libgtk...

gkoz commented 9 years ago

That last change was actually wrong. Backed it out.

GuillaumeGomez commented 9 years ago

All is good. I merge it. Thanks !