search

jeremyletang / rgtk

GTK+ bindings and wrappers for Rust (DEPRECATED SEE https://github.com/rust-gnome )
GNU Lesser General Public License v3.0
121 stars 22 forks source link

Use the new Type enum and move GValue to the glib crate #226

Closed oakes closed 9 years ago

oakes commented 9 years ago

This makes ListStore, TreeStore, and GValue use the new Type enum introduced in #225, so we no longer need the ffi::glib backdoor. It also moves GValue into the glib crate.

gkoz commented 9 years ago

I'm still slightly in favor of not reexporting anything from glib at all but that can be taken care of later.

One thing I forgot previously: as rgtk doesn't use G and Gtk prefixes in public APIs, GValue should be renamed to Value and its module accordingly.

oakes commented 9 years ago

Make sense, I did the rename. Ready to merge if all looks well.

gkoz commented 9 years ago

:+1:

GuillaumeGomez commented 9 years ago

Good for me so let's merge ! Thanks for your work !