jeremyletang / rgtk

GTK+ bindings and wrappers for Rust (DEPRECATED SEE https://github.com/rust-gnome )
GNU Lesser General Public License v3.0
121 stars 22 forks source link

Remove two fns from RecentFilter and RecentFilterInfo and RecentFilterFlags types #230

Closed gkoz closed 9 years ago

gkoz commented 9 years ago

This might be controversial.. :)

RecentFilter::filter and get_needed aren't intended for use in applications. RecentFilterInfo could also be used with add_custom which isn't implemented, seems to only be needed in obscure cases and would rely on a working callback system. Considering this, I find upkeeping this struct unjustified.

GuillaumeGomez commented 9 years ago

I'll wait a little before merging it if you don't mind. ^^

gkoz commented 9 years ago

Sure, this isn't blocking any other changes.