Closed gkoz closed 8 years ago
Moving all dialogs to one file is... just fine actually. I'm surprised it works so well. Waiting for travis and I merge it.
It's fine to let it settle for a while. There might be some loose ends.
As you wish ! Then come back to me when you're ready (otherwise I might be able to forget about it...).
This is the dialogs refactoring preview. It uses a copy of
AsRef
that isn't available in nightlies yet.gtk::dialog
consumesgtk::traits::dialog
and all dialogs fromgtk::widgets
.dialog
, get shorter names and better ergonomics.DialogFlags
is no longer exposed, the dialog is made modal iff a parent window is provided (TODO: header bar flag support, most likely with separate constructors).gtk3-sys
enums we don't reexport are replaced with consts. This might not be very nice from type checking point of view but is less hassle to use when implementing user-facing types.