search

jeremyletang / rgtk

GTK+ bindings and wrappers for Rust (DEPRECATED SEE https://github.com/rust-gnome )
GNU Lesser General Public License v3.0
120 stars 22 forks source link

Fix the build #247

Closed gkoz closed 9 years ago

GuillaumeGomez commented 9 years ago

Once again I was doing it. We should really try to figure a way to prevent the other before starting. ^^

gkoz commented 9 years ago

We could designate an issue e.g. #7 for reporting all the build breakages and fixes in progress. Or IRC, some IM, what have you. I hope you're not fixing the warning as well ;)

GuillaumeGomez commented 9 years ago

No, you started it so you finish it (punishment !). And the best would be to open an issue saying the build is broken and you (or I) are fixing it.

gkoz commented 9 years ago

I'm not sure I'll process all the deprecated stuff quickly, so might make sense to just merge these fixes for now.

gkoz commented 9 years ago

Cleaned up more wrong and deprecated stuff. Should be good to merge.

GuillaumeGomez commented 9 years ago

Once again, very nice job. By the way, you should add youself to the Cargo.toml authors. I totally forgot that and you did a lot more than enough to be in it !

gkoz commented 9 years ago

Right, I forgot about that too. :)

GuillaumeGomez commented 9 years ago

Make a PR for it !