jeremyletang / rgtk

GTK+ bindings and wrappers for Rust (DEPRECATED SEE https://github.com/rust-gnome )
GNU Lesser General Public License v3.0
121 stars 22 forks source link

Rust nightly changes #249

Closed gkoz closed 9 years ago

gkoz commented 9 years ago

The trivial casts lint is upon us. Whoever starts fixing the warnings can leave a message here.

gkoz commented 9 years ago

It seems the trivial_numeric_casts lint may become allow by default. https://github.com/rust-lang/rfcs/issues/1020

GuillaumeGomez commented 9 years ago

Oh come on ! They're can't be serious ! It was a pain in the pass to update some of my libs yesterday and they say I did it for nothing ? Seriously... Well, luckily, I didn't start doing it on rgtk...

gkoz commented 9 years ago

What's worse, in cases of i64 as c_long (which can be i32 or i64 on different platforms) and vice versa, removing the cast would be incorrect.

GuillaumeGomez commented 9 years ago

For that, I totally agree. But I was thinking that they somehow found a way to cast automatically if this is a c_type to waiting type. Seemed logical to me...