search

jeremyletang / rgtk

GTK+ bindings and wrappers for Rust (DEPRECATED SEE https://github.com/rust-gnome )
GNU Lesser General Public License v3.0
121 stars 22 forks source link

Refactor version features #252

Closed gkoz closed 9 years ago

gkoz commented 9 years ago

~~Rename the features to lower case to conform with Rust style. This is a [breaking change]~~ Make version features recursive to avoid enumerating the versions everywhere. Update the readme and travis.

GuillaumeGomez commented 9 years ago

Are you sure that if I use a gtk 3.10 version, I'll have access to this method for example ? And for the naming, I'm not sure this is needed. I'll wait @jeremyletang's opinion before doing anything on it if you don't mind.

gkoz commented 9 years ago

Are you sure that if I use a gtk 3.10 version, I'll have access to this method for example ?

The recursive feature declarations in Cargo.toml take care of that. In particular, gtktest uses MenuButton which is under feature = "gtk_3_6" and builds fine with just --features gtk_3_10.

gkoz commented 9 years ago

The renaming we could just postpone I guess, it's not that important.

gkoz commented 9 years ago

Removed the renaming bit.

GuillaumeGomez commented 9 years ago

Perfect, I merge it. Thanks for your work !