search

jeremylvln / Shulker

A Kubernetes operator for managing complex and dynamic Minecraft infrastructures, including game servers and proxies.
https://shulker.jeremylvln.fr/
GNU Affero General Public License v3.0
182 stars 14 forks source link

Ability to override Agent download #478

Closed jeremylvln closed 6 months ago

jeremylvln commented 6 months ago

Discussed in https://github.com/jeremylvln/Shulker/discussions/477

Originally posted by **TehNeon** March 22, 2024 It would be nice to have some way to either disable the download of the agent or a way to change the source of the download. The reasoning I propose this is that I'm building my own server images that have plugins baked into it (and proxy/paper jars) to prevent having to downloading assets from external sources. I'm also struggling from either my ISP or the repository host throttling my connection on downloading the agent causing it to take around 5 minutes just to finish the init-fs container on pod initialization.
TehNeon commented 6 months ago

I just rolled these changes out to my cluster and it appears now the init-fs container fails. It appears it fails regardless of modifying the newly added skipAgentDownload configuration. It does appear the agent skipping logic does work though based on turning it on/off, but in both cases the following errors occur.

ProxyFleet:

/mnt/shulker/config/init-fs.sh: line 15: SHULKER_PROXY_PLUGIN_URLS: parameter not set

MinecraftServerFleet:

/mnt/shulker/config/init-fs.sh: line 13: SERVER_WORLD_URL: parameter not set
jeremylvln commented 6 months ago

I removed a thing I couldn't understand from the init scripts (something I have done a long time ago and I wasn't recognizing why I did it), now I know why I did it. Will fix it ASAP.

Also I should really start to dig into automated end-to-end tests to ensure I do not break anything...

jeremylvln commented 6 months ago

Fixed in last commit. Very sorry for the trouble.

github-actions[bot] commented 6 months ago

:tada: This issue has been resolved in version 0.8.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: