search

jeremyolliver / gvis

Rails plugin for easy embedding charts with Google Visualization API
http://github.com/jeremyolliver/gvis
MIT License
49 stars 22 forks source link

event handlers #16

Open gasova opened 13 years ago

gasova commented 13 years ago

Do you plan to add support for event handlers for google visualization API ?

Kind Regards.

gasova commented 13 years ago

i'm new on github i don't know how to share my code update on this plugin, i succeeded adding select event handler at least it works for tables... and calls external javascript function where event should be handled.

jeremyolliver commented 13 years ago

Hi,

The usual method for contributing patches/features on Github is to fork the project (top right of the github interface), create a new git branch for the feature, and to push the code to that. This branch can be submitted as a pull request, or I can pull in the changes myself.

I'd be happy to add event support as a feature, especially if you've already done some work to get this implemented. Let me know if you push up the code for that.

Cheers, Jeremy

gasova commented 13 years ago

sorry for my late response, as soon as i find and extensible way i will share it with you, for now i just succeeded to add a simple select event. But did not had time to test in real, i'm just able to show an alert box with one cell value.

Cheers,

Gökçe.

alecguintu commented 12 years ago

I have one at my fork, added a fourth parameter (callbacks) to visualization that accepts a hash of callbacks

{:ready => ready_func(), :onmouseout => mousing_out}

Don't know if I implemented it correctly or if preferred in another way but it works for me now.

What do you guys think?