jeremyomer / KidneyExchange.jl

MIT License
3 stars 2 forks source link

16 file format descriptions seem off #17

Closed pnavaro closed 5 months ago

pnavaro commented 6 months ago

Bonjour Ayse et Jeremy

Suite au ticket #16 , j'ai remarqué que le package ne fonctionnait pas avec les fichiers wmd qu'on peut trouver sur cette page https://www.preflib.org/dataset/00036 .

J'ai créé une nouvelle fonction pour lire ces fichiers preflib dans le fichier src/instance/matching_instance.jl

J'ai ajouté une condition dans le constructeur du type Instance pour conserver le comportement initial.

A bientôt

Pierre

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.81%. Comparing base (a7ccc09) to head (5b61dbd).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17 +/- ## =========================================== + Coverage 55.12% 70.81% +15.68% =========================================== Files 21 22 +1 Lines 2418 2546 +128 =========================================== + Hits 1333 1803 +470 + Misses 1085 743 -342 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pnavaro commented 5 months ago

resolves #18 resolves #16

pnavaro commented 5 months ago
pnavaro commented 5 months ago

Resolves #16 with the new function read_wmd_file that allows to read the new prefab format with headers.