search

jeremyong / klein

P(R*_{3, 0, 1}) specialized SIMD Geometric Algebra Library
https://jeremyong.com/klein
MIT License
756 stars 56 forks source link

Fix MSVC Warnings C4100/C4101 #3

Closed Faaux closed 4 years ago

Faaux commented 4 years ago

Due to 'if constexpr' MSVC complains about: C4100: unreferenced formal parameter C4101: unreferenced local variable

Uses [[maybe_unused]] (C++17)

jeremyong commented 4 years ago

Thanks! Do you think you could run clang format on the file? I think it will put the attributes on the same line in front of the function parameter

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Faaux commented 4 years ago

Just ran it, and shortend a comment to keep it on one line.