search

jeremyramin / terminal-plus

A terminal package for Atom, complete with themes and more.
https://atom.io/packages/terminal-plus
MIT License
481 stars 254 forks source link

Themes not working in Atom 1.8.0 #284

Open havlicekdom opened 8 years ago

havlicekdom commented 8 years ago

Hi,

since the last update of Atom to version 1.8.0 (latest one) the themes for terminal stopped working for me. (see screenshot)

screen shot 2016-06-13 at 10 46 30 2

Same thing happens with whatever theme I choose.

I'm on OSX 10.11.5, Atom version 1.8.0, node-gyp installed.

fusion809 commented 8 years ago

As I don't have write permissions to this repo I can't fix it directly, but you may wish to use my package terminal-fusion (which is a fork of the platformio-ide-terminal package, which itself is a fork of this package), as from what I can tell its themes are working fine, granted I'm working on Arch Linux and not OS X, so I can't be certain as to whether it will fail on OS X. But if it does, I will see what I can do to fix it, provided of course you alert me to it by starting a new issue there. You can install my package via running:

apm install terminal-fusion

Normally I wouldn't try to steer people away from an existing package, especially not a package I love too like terminal-plus but its maintainer hasn't been contributing to GitHub in quite some time so I doubt this issue of yours will be resolved anytime soon.

vekien commented 8 years ago

@fusion809 Themes don't work in yours either, on OSX, they do nothing. And your repo doesn't have Issues enabled.

fusion809 commented 8 years ago

Sorry didn't realize no issues were allowed. I have since dropped OS X support, so I'm afraid my earlier comment is now invalid.