jeremyramin / terminal-plus

A terminal package for Atom, complete with themes and more.
https://atom.io/packages/terminal-plus
MIT License
481 stars 254 forks source link

Terminal Seems to Crash #98

Open patrickml opened 8 years ago

patrickml commented 8 years ago

Iv had a recurring issue when working with this package on Atom.

I am working on a MeteorJS application I run my application from the terminal and after awhile the terminal seems to crash without saying it does. What i mean is it freezes and my application stops running. I have to close the terminal and restart my application.

jeremyramin commented 8 years ago

If you can provide me with additional information about your system, I can reproduce this and find out what is going on.

  1. Operating system
  2. A sample for me to run. The best thing would be a link to a sample provided by the MeteorJS tutorials that closely resembles what you are doing. That way I can try the commands that you are using to get it to freeze.
patrickml commented 8 years ago
  1. OS X El Capitan 10.11.1
  2. Sadly I cannot provide anything like what I am doing, but I can tell you I do use cmd + k a lot to clear the screen and now i'm wondering if that has anything to do with this issue?
patrickml commented 8 years ago

Also this error seems to pop up but removing the plugin doesnt work https://github.com/jeremyramin/terminal-plus/issues/51

jeremyramin commented 8 years ago

...I do use cmd + k a lot to clear the screen and now i'm wondering if that has anything to do with this issue?

This could be what is causing this. I'll take this into consideration while I try to reproduce your issue.

jeremyramin commented 8 years ago

Also this error seems to pop up but removing the plugin doesnt work #51

This is interesting. Now does this happen right after your terminal freezes?

patrickml commented 8 years ago

Yup and it seems to be after I clear the terminal. But that error doesn't always pop up On Wed, Nov 18, 2015 at 4:31 PM Jeremy Ebneyamin notifications@github.com wrote:

Also this error seems to pop up but removing the plugin doesnt work #51 https://github.com/jeremyramin/terminal-plus/issues/51

This is interesting. Now does this happen right after your terminal freezes?

— Reply to this email directly or view it on GitHub https://github.com/jeremyramin/terminal-plus/issues/98#issuecomment-157870927 .

jeremyramin commented 8 years ago

In that case, I believe what is happening is that your terminal process is closing for some reason. When the process closes, it appears as if it has frozen because it should block your input at that point. When it does not block your input, you get the error you specified because Terminal-Plus tried to send a message to the closed process.

patrickml commented 8 years ago

Yeh that would make sense. Anything you would like me to try?

jeremyramin commented 8 years ago

I'm looking into the cmd-k clearing command. I'm going to try and see if this command would cause your terminal process to close for some reason. I'lll let you know if there is anything I need from you. Thanks.

jeremyramin commented 8 years ago

I tried running my own meteor app from the terminal. Like you said, I occasionally cleared the screen with cmd-k. I was not able to reproduce your issue. However, I recently changed how the cmd-k clear works. Can you confirm that the issue still exists as of the latest version of Terminal-Plus?

patrickml commented 8 years ago

I will check it out for sure and let you know how things play out.