Closed jumanjiman closed 2 years ago
Hi @jeremyschulman
TYVM for this project. I've learned a great deal with it!
I have tested this PR with netbox in our internal network, and it does what it claims to do. Specifically, a user with groups can log in and get permissions to do stuff, but a user without groups logs in but has zero permissions and cannot even view stuff. It thus avoids a traceback in the code when the IdP omits the groups attr.
LMK if I've made some conceptual error.
TY, -paul
Hi @jumanjiman - my apologies for being MIA responding. I've reviewed the PR and it appears to be a good update. I would like to dev-test this in my environment just to do the "measure twice, cut once" thing. Really appreciate your time and contribution.
@jumanjiman - I have not forgotten :-) I am planning to test validate this next week after the Labor Day holiday.
Thanks for the update, and have a wonderful weekend!
@jeremyschulman gentle bump
@jumanjiman - yikes, my apologies! I'll get this done today.
deployed to PyPi v2.4. Thank you!
Thank you!
Comments in code, but compare...
User who does not have any groups (expect empty groups claim, but get missing claim):
User who does have groups: