search

jeremyschulman / netbox-plugin-auth-saml2

Netbox plugin for SSO using SAML2
119 stars 21 forks source link

Update for NetBox 4.0 syntax #78

Closed squintfox closed 3 months ago

squintfox commented 3 months ago

@jeremyschulman for your review. This PR updates the class name for a breaking change required for it to work in NetBox 4.0. It will make the plugin no longer backward compatible with previous versions of NetBox.

ProbstenHias commented 3 months ago

Unfortunately this is not quite enough for it to work with the 4.0.x version.

As this issue here also describes the new version does no longer user djangos Group. We have to do a from netbox.authentication import Group here instead.

Does anyone know if this repo is still maintained and a new release is foreseeable?

jeremyschulman commented 3 months ago

@ProbstenHias - unfortunately I am not really actively developing on this repo. I am happy to take PRs and roll releases. If your PR resolves the issue I can do that task quickly

jeremyschulman commented 3 months ago

New version PR completed from @ProbstenHias https://pypi.org/project/netbox-plugin-auth-saml2/

squintfox commented 3 months ago

Thanks all, I missed those extra pieces in my PR. @ProbstenHias thanks for the update.