jeremytammik / RevitLookup

Interactive Revit RFA and RVT project database exploration tool to view and navigate BIM element parameters, properties and relationships.
http://thebuildingcoder.typepad.com
MIT License
1.03k stars 294 forks source link

Error when snoop symbol geometry cad link #117

Closed chuongmep closed 2 years ago

chuongmep commented 2 years ago

Image Problem : image File sample : Drawing1.zip revitfile.zip Step by step :

  1. Click to Symbol and click ok image
    1. Click to SymbolGeometry

image Video : https://user-images.githubusercontent.com/31106432/140770842-480dc41e-ffab-46bd-8d68-f3e3b378344f.mp4

jeremytammik commented 2 years ago

The Arc object is a pure memory-only geometry object. It is not a database resident Revit Element. Therefore, the RevitLookup code should not allow it to be snooped as if it were. -- https://www.revitapidocs.com/2022/1f5f541e-9335-aef3-0e75-59eed9ae2221.htm -- Something may be wrong with the snoop routing. Maybe it should terminate before drilling down into the geometry objects, or treat them differently than the database elements derived from the Element base class.

Nice3point commented 2 years ago

Fixed изображение

Exceptions are now displayed correctly. The very throwing of the exception is caused by the fact that the object is unloaded from memory when you call another method. I just ran into this when I was developing my plugin. This is how the get_Geometry () method works.

Also, when throwing an exception, the error message is taken from the nested one, instead of the wrapping one.

Nice3point commented 2 years ago

Finally, the error messages will be more informative 🙃

изображение

Nice3point commented 2 years ago

@jeremytammik can you set the dev branch by default? its content will be displayed on the github page, it makes sense since it is updated more often изображение

jeremytammik commented 2 years ago

@Nice3point yes, sure, thank you for the good suggestion! done.

jeremytammik commented 2 years ago

error messages will be more informative

wow, brilliant! very useful feature! strong didactical learning support :-)