jeremytammik / RevitLookup

Interactive Revit RFA and RVT project database exploration tool to view and navigate BIM element parameters, properties and relationships.

http://thebuildingcoder.typepad.com

MIT License

1.03k stars 294 forks source link

Optional Snoop Selection in Modify Tab #152

Closed ricaun closed 1 year ago

ricaun commented 1 year ago

Summary of the Pull Request

Feature to enable/disable the Snoop Selection in Modify Tab in the setting.

What is this about:

Add enable/disable the Snoop Selection in Modify Tab in the setting.
Add Snoop Selection Command in the RevitLookup (#150)
Add Always Command Availability in the Dashboard command

Description: I tried to follow your pattern to create the new setting, everything looks great except Application.UpdateModifyPanelVisibility is hardcoded in the SettingViewModel, I didn't know if I should create an interface in the ISettingsService and move the Application.UpdateModifyPanelVisibility to the SettingsService.

Quality Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

Nice3point commented 1 year ago

For now, let's hold off all PR for 2 weeks to gather feedback from all possible people and developers. We will come back to this theme later and make this option

ricaun commented 1 year ago

For now, let's hold off all PR for 2 weeks to gather feedback from all possible people and developers. We will come back to this theme later and make this option

Nice3point commented 1 year ago

Ok

We will definitely add this, but first we need to decide in what way and how best for everyone

ricaun commented 1 year ago

No worry, I gonna use my version and see if I find some other issue.

Nice3point commented 1 year ago

@ricaun I have greatly simplified the code to add a button, please take a look. This also allowed to add hotkeys to it. If you want, you can check the source code to make the button always available on the ribbon without using a controller

https://github.com/jeremytammik/RevitLookup/commit/fd54b8bab07fcb49e79b230cc11649215f993c95

ricaun commented 1 year ago

@ricaun I have greatly simplified the code to add a button, please take a look. This also allowed to add hotkeys to it. If you want, you can check the source code to make the button always available on the ribbon without using a controller

fd54b8b

Interesting, I never use this createPushButton.

Usually, I create the command in the normal way and move the Autodesk.Window.RibbonPanel or Autodesk.Window.RibbonItem using the m_RibbonItem as you did.

I don't know how you gonna synchronize the change without resetting Revit in your current code. Gonna be easier to create using the Revit way and copy the RibbonItem and put in the Modify.

Nice3point commented 1 year ago

I don't know how you gonna synchronize the change without resetting Revit in your current code. Gonna be easier to create using the Revit way and copy the RibbonItem and put in the Modify.

@ricaun I have added a live ribbon update now, update your fork 😉