search

jeremytregunna / ruby-trello

Implementation of the Trello API for Ruby
MIT License
719 stars 237 forks source link

Remove rest-client dependency in the gemspec and default to faraday #308

Closed armilam closed 2 years ago

armilam commented 2 years ago

What does this PR do?

This is a followup to https://github.com/jeremytregunna/ruby-trello/pull/307. This removes the gemspec dependency on rest-client to allow apps the option to remove their dependency on rest-client in favor of faraday (or other http clients in the future).

Why are we doing this? Any context or related work?

rest-client is out of date and does not appear to be actively maintained. This allows apps to remove the outdated gem from their dependency trees.

Where should a reviewer start?

The changes here are all configuration, so perhaps the best place to start is by running the tests.

Manual testing steps?

Include ruby-trello in a rails app and test it configured to use each of rest-client and faraday.

armilam commented 2 years ago

I know you just released the minor version update, so I hope it's not too early to submit this! My own end goal is to remove rest-client from my dependency tree, so this will be my last step toward that goal.

armilam commented 2 years ago

@hoppergee do you think we could merge and release this? rest-client continues to decay and it's holding me back from updating other gems. It would be nice to drop it as a requirement, and this is my last roadblock.

Thanks!

hoppergee commented 2 years ago

Yes, you're right. I will merge and cut the release.

armilam commented 2 years ago

Thank you! I appreciate it.