jeremyvii / vs-docblockr

DocBlockr for Visual Studio Code
GNU Lesser General Public License v3.0
21 stars 8 forks source link

typing `/**` and pressing enter does duplicate the `/**` tag #63

Closed jdeniau closed 4 years ago

jdeniau commented 4 years ago

Describe the bug A clear and concise description of what the bug is.

typing /** and pressing enter does duplicate the /** tag. See the following video

dockblockr small

To Reproduce

  1. Go on top of a function
  2. Type /**
  3. Press enter
  4. The first line does now contain /**/**

Expected behavior Do not duplicate /**

Code Snippet If applicable, code snippet you tried to try to apply docblock too

Screenshots If applicable, add screenshots to help explain your problem.

Enviroment (please complete the following information):

jeremyvii commented 4 years ago

I am having trouble recreating this on my end. Does this happen for you in Typescript as well?

jdeniau commented 4 years ago

Yes it does. I tried disabling all other extension, and still the issue 🤔

jeremyvii commented 4 years ago

Strange, I am on Ubuntu and it looks like you're on Windows. Could be an OS difference? I can try on a Windows machine later and see if I get the same result.

jdeniau commented 4 years ago

Great. I will try on my laptop on Fedora too 👍

jeremyvii commented 4 years ago

@jdeniau I've been having trouble getting my Windows machine to cooperate with me. However, I did find where I could improve how the extension was currently placing the docblock snippets. Would you be willing to test my branch on your machine?

You would need to

I can set you as the reviewer on #64 if you are willing to help test this.

jdeniau commented 4 years ago

I tried every language and it does work now on my machine 👍

jeremyvii commented 4 years ago

Awesome, thanks!