search

jeremywen / JW-Modules

VCV Rack Modules
BSD 3-Clause "New" or "Revised" License
216 stars 26 forks source link

Make code work with Rack 1.0 #35

Closed baconpaul closed 5 years ago

baconpaul commented 5 years ago

Hi!

Here's a pull request that makes everything at least not dump core for me on a mac in surge 1.0. I don't know your modules well enough to know if they are working properly but they don't segfault for me with these diffs.

1: Check module null 2: Return value from functions with no return value otherwise 3: Kill depracation warnings in makefile so you can see what's going on

jeremywen commented 5 years ago

thank you , i manually made these changes along with mine