jeremywen / JW-Modules

VCV Rack Modules
BSD 3-Clause "New" or "Revised" License
216 stars 26 forks source link

8face restoring noteseq patterns #44

Closed midiguru closed 5 years ago

midiguru commented 5 years ago

I'm reporting this both to you and to stoermelder, as I have no way of knowing where the problem originates. 8vert_noteseq_bug.zip When 8face recalls the data in NoteSeq, certain of the recalled notes are displayed correctly, but they don't reach the playback mechanism. Re-editing and re-storing the notes will start to correct the problem, if new notes are entered, but the fix is quirky, as this video illustrates.

The missing notes seem consistently to be in the later part of the pattern. If you need more info, I'm at midiguru23@gmail.com.

midiguru commented 5 years ago

Following up on this ... stoermelder suggested a test that proves the problem is largely (or entirely) in the NoteSeq preset storing/recall mechanism. I can remove 8face from the patch entirely, then save a couple of defective presets to disk. They will still be defective when I reload them. How a defective preset gets created in the first place is a slightly different question -- possibly 8face is causing that!

midiguru commented 5 years ago

But no. Even with 8face entirely out of the picture. NoteSeq fails to save and load its own preset data correctly. Definite bug. (I'm in Windows 7, using JW 1.0.6.)

jeremywen commented 5 years ago

Thanks for digging into this. I just got home and I can reproduce it myself with just a preset and then clearing before i load the preset. I think it has to do with caching. I cache the columns and clear the cache when they change. So I bet I need to clear the cache on load of a preset.

jeremywen commented 5 years ago

can you try this build? JW-Modules-1.0.6-win.zip