jeremywestAMX / ember-plus

Automatically exported from code.google.com/p/ember-plus
0 stars 0 forks source link

Allow objects of libember::glow::GlowRootElementCollection to be automatic #13

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
At the moment the library forces to use 
libember::glow::GlowRootElementCollection::create() in to create an object of 
this type (and as consequence, a delete is required). Most often, this is not 
required because this object is only used to create a message, serialize it and 
throw it away.

I propose to stop forcing this.

Original issue reported on code.google.com by nullable...@gmail.com on 20 Jun 2013 at 8:34

GoogleCodeExporter commented 9 years ago
My solution would be to just make the default constructor public and set the 
tag to GlowTags::Root().
Does anybody have other suggestions for this?

Original comment by p...@l-s-b.de on 27 Jun 2013 at 3:02

GoogleCodeExporter commented 9 years ago
@Philip:

I added a patch to solve this issue. Please review the changes and let me know 
if the changes are ok for you.

I marked libember::glow::GlowRootElementCollection::create() as deprecated 
(doxygen command) - i would remove it after the next release.

Original comment by nullable...@gmail.com on 4 Nov 2013 at 7:46

Attachments:

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r76.

Original comment by nullable...@gmail.com on 5 Nov 2013 at 7:13

GoogleCodeExporter commented 9 years ago
@ Philip:

I applied the patch, please review and change or revert it, if not suitable.

Original comment by nullable...@gmail.com on 5 Nov 2013 at 7:14

GoogleCodeExporter commented 9 years ago
Cool - thanks, Simon!

Original comment by p...@l-s-b.de on 5 Nov 2013 at 8:38