Add 'nil' support for unsetting variable(s)

jeremyworboys / node-kit

Node based compiler for .kit files.

MIT License

15 stars 8 forks source link

Add 'nil' support for unsetting variable(s) #17

Closed mstalfoort closed 9 years ago

mstalfoort commented 9 years ago

Usecase

According to Codekit help (https://incident57.com/codekit/help.html#kit) "Nil Variables" is supported, yet by using the command line version and setting a variable to "nil" will output that exact value in the HTML end result.

jeremyworboys commented 9 years ago

The diff looks fine. If you add a test case for the change I'll merge.

mstalfoort commented 9 years ago

cool, can you help me out a bit on writing the test, i don't have much experience with it yet

fatso83 commented 9 years ago

@mstalfoort : just look at how it is done, then do the developer boogie:

copy
paste
modify
run

If npm test runs afterwards you are good to go :dancers: . Basically just add a kit file and the expected output to the test/fixtures dir and make kit compile it.

mstalfoort commented 9 years ago

updated, can you please check again

jeremyworboys commented 9 years ago

Looks great. Thanks!