search

jeremyworboys / node-kit

Node based compiler for .kit files.
MIT License
15 stars 8 forks source link

Added support for relative paths in imports #6

Closed aral closed 10 years ago

aral commented 10 years ago

File paths in imports may be relative. Previously, node-kit was failing on these. This adds support for use of relative paths in imports specified both with and without underscore-prefixed partial syntax.

jeremyworboys commented 10 years ago

Hey Aral,

I don't quite understand the issue this fixes. Can you able to provide a test case that is currently failing and would be resolved by your changes?

aral commented 10 years ago

I was including ../head and it was failing on that. Will look to create a test case if you still need it when I get a moment :)

Aral

Sent from my iPhone

On 2 Jun 2014, at 00:01, Jeremy Worboys notifications@github.com wrote:

Hey Aral,

I don't quite understand the issue this fixes. Can you able to provide a test case that is currently failing and would be resolved by your changes?

— Reply to this email directly or view it on GitHub.

jeremyworboys commented 10 years ago

Thanks. If you get a chance to write a test that would be great, otherwise I'll throw one together tomorrow and get this merged.

jeremyworboys commented 10 years ago

I've tried a few approaches and I can't produce a failing test that this fixes.

Can you add failing test case and update the pull request. You'll also need to pull from master as I am pushing some changes today.

fatso83 commented 10 years ago

Maybe it's an operating system specific thing? Unix vs Windows file paths or something like that. Non-Cygwin Node running in CygWin for instance.

robotlovesyou commented 10 years ago

I have added the failing/passing test to the fork @aral created as you requested. The added test fails in the master branch and passes in the patch-1 branch.

aral commented 10 years ago

Thanks, Andy :) 

Aral --  Aral Balkan We’re making a smartphone where you are in control. http://indiephone.eu

On 26 June 2014 at 16:40:16, Andrew Smith (notifications@github.com) wrote:

I have added the requested failing/passing test to the fork @aral created as you requested. The added test fails in the master branch and passes in the patch-1 branch.

— Reply to this email directly or view it on GitHub.

jeremyworboys commented 10 years ago

Awesome, thanks. Merged.