search

jeresig / pulley

Easy Github Pull Request Lander
MIT License
175 stars 24 forks source link

don't add fixes "#????" if a ticket reference is not present. #28

Closed mikesherov closed 12 years ago

mikesherov commented 12 years ago

There should be an option that if a ticket number isn't present, pulley should:

  1. allow the pull to go through and not print "#????".
  2. not allow the pull to go through.
sindresorhus commented 12 years ago

What is the use case of not allowing it to go through?

mikesherov commented 12 years ago

If you want to make sure all pull requests reference an issue.

sindresorhus commented 12 years ago

Ok, duh, though I would never pulley a pull request without looking at the pull first, where I would see if it had an issue number, but it might be a good safeguard.

2, Instead of not allowing it, maybe ask the user what to do: couldn't find a issue number, continue [y/n]

mikesherov commented 12 years ago

Good idea. Maybe even prompt for that issue number right then and there.

sindresorhus commented 12 years ago

Yes, that would be useful ;)